Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable console warning for native crypto modules #111

Merged
merged 1 commit into from Sep 9, 2022

Conversation

aarne
Copy link
Contributor

@aarne aarne commented Sep 9, 2022

As discussed in #109

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2022

Codecov Report

Merging #111 (9832ca4) into master (f6d237d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   92.90%   92.94%   +0.04%     
==========================================
  Files          16       16              
  Lines        5963     5984      +21     
==========================================
+ Hits         5540     5562      +22     
+ Misses        423      422       -1     
Impacted Files Coverage Δ
lib/toolbox.js 89.82% <ø> (+0.23%) ⬆️
lib/response.js 97.56% <100.00%> (+0.01%) ⬆️
lib/validator.js 92.29% <100.00%> (+0.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Hexagon
Copy link
Member

Hexagon commented Sep 9, 2022

Cool! Could you please bump version to 3.3.3 in package.json, then we're good to go 👍

@JamesCullum
Copy link
Member

I dont think we need to bump the version for such a minor, cosmetic change - we can just roll it out with the next change

@JamesCullum JamesCullum merged commit adaab4d into webauthn-open-source:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants