From 15c39ed81246d2262ac2cb637e7ba914a8d12b68 Mon Sep 17 00:00:00 2001 From: Greg Myers Date: Tue, 11 Jan 2022 09:19:12 -0700 Subject: [PATCH 1/3] Fix typos in REVIEW.md and TESTING.md REVIEW.md:10: unneccessary -> unnecessary REVIEW.md:23: succesfully -> successfully TESTING.md:55: programatically -> programmatically --- REVIEW.md | 4 ++-- TESTING.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/REVIEW.md b/REVIEW.md index 19d1abe230f..78e910befad 100644 --- a/REVIEW.md +++ b/REVIEW.md @@ -7,7 +7,7 @@ Only published PRs will be considered for review. Draft PRs will be considered i ## Rules * [ ] PR follows the provided [template](.github/PULL_REQUEST_TEMPLATE.md). -* [ ] PR doesn't contain unneccessary changes. +* [ ] PR doesn't contain unnecessary changes. * [ ] The changed code preserves the conventions and stylistic consistency of the project. * [ ] PR uses labels accordingly. (new labels may be suggested) * [ ] PR includes unit and e2e tests if related to any logic changes. @@ -20,7 +20,7 @@ Only published PRs will be considered for review. Draft PRs will be considered i * [ ] Any new files contain the web3.js file header. * [ ] The documentation was updated (if applicable). * [ ] The CHANGELOG was updated accordingly. - * [ ] The CI with QA passes succesfully. + * [ ] The CI with QA passes successfully. * [ ] The CI logs were manually checked to ensure false positives were not reported. * [ ] All comments have been addressed. * [ ] Doesn't add undue maintenance burden. diff --git a/TESTING.md b/TESTING.md index a21c4a1a484..1def1b4fb22 100644 --- a/TESTING.md +++ b/TESTING.md @@ -52,7 +52,7 @@ in their mocha test description and runs them against: These tests are grouped in files prefixed by "e2e", ex: `test/e2e.method.call.js`. Additionally, there are conventional unit tests postfixed `.ganache.js` which spin up a ganache -server programatically within mocha. This pattern is useful if you want to +server programmatically within mocha. This pattern is useful if you want to control client configuration for a specific case, test against multiple independent providers, etc. **"Real world" tests** From 85906c797afb3d2c87a5da3e5b84eaf939f69074 Mon Sep 17 00:00:00 2001 From: greg Date: Fri, 14 Jan 2022 16:39:45 -0700 Subject: [PATCH 2/3] Add typofix in REVIEW.md, TESTING.md to changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9ed922075ca..4b7f0974a61 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -488,6 +488,7 @@ Released with 1.0.0-beta.37 code base. ### Fixed - Fix readthedoc's build for web3js documentation (#4425) - Fix response sorting for batch requests (#4250) + - Fix typos in REVIEW.md and TESTING.md (#4691) ### Changed From adedf194ae5445fba4c301295488fd73ee721834 Mon Sep 17 00:00:00 2001 From: jdevcs <86780488+jdevcs@users.noreply.github.com> Date: Wed, 19 Jan 2022 17:28:43 +0100 Subject: [PATCH 3/3] changelog update --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b27e4d2ff15..beb5cba183d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -486,7 +486,6 @@ Released with 1.0.0-beta.37 code base. ### Fixed - Fix readthedoc's build for web3js documentation (#4425) - Fix response sorting for batch requests (#4250) - - Fix typos in REVIEW.md and TESTING.md (#4691) ### Changed @@ -506,6 +505,7 @@ Released with 1.0.0-beta.37 code base. - Correction in documentation for `web3.eth.accounts.signTransaction` (#4576) - Updated README to include Webpack 5 create-react-app support instructions (#4173) - Update the documentation for `methods.myMethod.estimateGas` (#4702) +- Fix typos in REVIEW.md and TESTING.md (#4691) ### Changed - Muted E2E gnosis dex tests in CI until fix for issue #4436 is applied (#4701)