Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get the CI for the Truffle MR to run successfully after re-basing again and fixing the unskipped tests #6442

Closed
Tracked by #6390
Muhammad-Altabba opened this issue Sep 19, 2023 · 1 comment
Closed
Tracked by #6390

Get the CI for the Truffle MR to run successfully after re-basing again and fixing the unskipped tests #6442

Muhammad-Altabba opened this issue Sep 19, 2023 · 1 comment
Assignees
@Muhammad-Altabba
Labels
4.x 4.0 related

Comments

@Muhammad-Altabba
Copy link
Contributor

This is just to reference work done as part of the MR: trufflesuite/truffle#5393. And this involves:

  • Rebase to the latest and resolve the new merge conflicts.
  • Fix a unit test failing for packages/core console
  • Increase timeout at some tests
  • Update yarn.lock
@Muhammad-Altabba
Copy link
Contributor Author

The CI is running now: https://github.com/trufflesuite/truffle/actions/runs/6234872212/job/16922988549?pr=5393

@Muhammad-Altabba Muhammad-Altabba self-assigned this Sep 19, 2023
@Muhammad-Altabba Muhammad-Altabba added the 4.x 4.0 related label Sep 19, 2023
@Muhammad-Altabba Muhammad-Altabba mentioned this issue Sep 19, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Muhammad-Altabba Muhammad-Altabba

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Muhammad-Altabba