Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3.storage does not skypack #220

Open
olizilla opened this issue Jul 28, 2021 · 6 comments
Open

web3.storage does not skypack #220

olizilla opened this issue Jul 28, 2021 · 6 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@olizilla
Copy link
Contributor

Trying to import web3.storage from skypack like so:

<script type="module">
import { Web3Storage } from 'https://cdn.skypack.dev/web3.storage'
</script>

fails with:

Uncaught TypeError: null has no properties
    <anonymous> https://cdn.skypack.dev/-/uint8arrays@v2.1.8-V4yKmFZA5flfvKIy9mKK/dist=es2020,mode=imports/unoptimized/util/bases.js:2
bases.js:2:17

see: https://codepen.io/olizilla/pen/wvdmJXK

@olizilla olizilla added the kind/bug A bug in existing code (including security flaws) label Jul 28, 2021
@vasco-santos vasco-santos self-assigned this Jul 28, 2021
@vasco-santos
Copy link
Member

This is currently blocked on figuring out a solution for CI tests with Electron on an ESM project (Electron does not support ESM).
We can compile ESM tests to CJS and use them for tests in Electron, which would be great but does not work with a monorepo, where one package depends on the other. Given we ship the content of dist (generated by ipjs with exports for cjs/esm), but in the monorepo tests, we will not import the dist content.

@dchoi27
Copy link
Contributor

dchoi27 commented Feb 11, 2022

Let's check up on this (see if any movement) and make a call if we should just close this given that we have a solution for users and Skypack is no longer in active development. cc @alanshaw

@alanshaw
Copy link
Member

alanshaw commented Feb 21, 2022

It's currently failing with:

Uncaught TypeError: null has no properties
    <anonymous> https://cdn.skypack.dev/-/hamt-sharding@v2.0.1-2WfbeukgfNYgnLr54HmK/dist=es2019,mode=imports/optimized/hamt-sharding.js:4

There's some changes I made to hamt-sharding that need to be released. I would like to at least wait for that to happen before we close this.

@vasco-santos
Copy link
Member

Update on current known errors

image

From previous experience, once one issue is addressed, next pops in, so there is no clear indication on how many will exist

@sonika-25
Copy link

Did you solve this? I am also getting 'cannot destructure' error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

5 participants