Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cause of Taskcluster failures are too hard to figure out #15412

Closed
foolip opened this issue Feb 15, 2019 · 10 comments
Closed

Cause of Taskcluster failures are too hard to figure out #15412

foolip opened this issue Feb 15, 2019 · 10 comments

Comments

@foolip
Copy link
Member

foolip commented Feb 15, 2019

In #15401 and many other issues, people have asked about why Taskcluster is failing. It is currently too much work to understand failures.

For ease of reference, here's how I figure it out:

Some known failure causes are listed in #14210.

Understanding a Taskcluster failure is too much work.

@jgraham will the Checks API integration allow us to improve this at some point? Ideally we'd be able to populate the details of the checks page with an artifact containing markdown.

@jgraham
Copy link
Contributor

jgraham commented Feb 15, 2019

@owlishDeveloper might be better able to answer this, but I'd certainly like some way to produce a markdown artifact that ends up being the content of the checks API.

We could also consider adding the wpt repo to treeherder, which has features for extracting errors from a log, and would also allow us to use the classification facilities to track different causes of failure. But we'd still need a way to link to the push on treeherder.

@foolip
Copy link
Member Author

foolip commented Oct 7, 2019

Ping @owlishDeveloper, is a way to supply arbitrary markdown for the Taskcluster integration using GitHub Checks planned?

@stephenmcgruer
Copy link
Contributor

Nobody currently owns driving this, so dropping to backlog. Note that we do have a Q2 OKR to try to migrate to the Taskcluster Checks API, but that alone will only reduce this flow by at most one click. We need the ability mentioned in #15412 (comment) to push text to the GitHub Checks description.

@stephenmcgruer
Copy link
Contributor

stephenmcgruer commented Jul 10, 2020

The WPT Taskcluster Checks migration is (mostly) complete, so this should now be possible to address. https://docs.taskcluster.net/docs/reference/integrations/github/checks#custom-text-output-in-checks lays out the approach for producing an 'output' object for GitHub Checks:

... it looks for an artifact on the task named public/github/customCheckRunText.md and uses the artifact content as the check run text ...

For example:

payload:
  ...
  artifacts:
    public/github/customCheckRunText.md:
      type: file
      path: checkrun.md

One can also override task.extra.github.customCheckRun.textArtifactName to change the directory that is checked.

@stephenmcgruer
Copy link
Contributor

First experiment on lint: https://github.com/web-platform-tests/wpt/pull/24556/checks?check_run_id=858217231

We'll probably want to do some legwork to dump something a bit more readable (this is just log to file) but not bad.

@stephenmcgruer
Copy link
Contributor

#24741 just added this output for stability checks (woo). It looks like:

Screenshot 2020-08-04 at 10 44 49

@foolip
Copy link
Member Author

foolip commented Aug 20, 2020

That is sweet, thanks @stephenmcgruer! I've used this view a few times this week already.

@stephenmcgruer
Copy link
Contributor

#24556 added one for lint too:

image

The various unittest setups could probably also do with some sort of output like this, but sadly they are much harder to integrate with (afaik), so I won't be tackling them currently. This issue can remain to track those.

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Sep 11, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556
@foolip
Copy link
Member Author

foolip commented Sep 14, 2020

@stephenmcgruer I would consider the original problem I reported here resolved. Closing this issue in celebration would be appropriate I think, and maybe open new issues for the case that remains? That'll probably be less important than what you've already addressed.

seinlin pushed a commit to kaiostech/gecko-b2g that referenced this issue Sep 14, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 16, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556

UltraBlame original commit: a6e4b389013941a0c67a2ed4b32796bfa59bcb23
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 16, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556

UltraBlame original commit: a6e4b389013941a0c67a2ed4b32796bfa59bcb23
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 16, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556

UltraBlame original commit: a6e4b389013941a0c67a2ed4b32796bfa59bcb23
@stephenmcgruer
Copy link
Contributor

@stephenmcgruer I would consider the original problem I reported here resolved. Closing this issue in celebration would be appropriate I think, and maybe open new issues for the case that remains? That'll probably be less important than what you've already addressed.

Seems reasonable. #25663 can be its successor

ambroff pushed a commit to ambroff/gecko that referenced this issue Nov 4, 2020
…Checks output file, a=testonly

Automatic update from web-platform-tests
[Taskcluster] Make lint create a GitHub Checks output file (#24556)

See web-platform-tests/wpt#15412
--

wpt-commits: 8420fdfa2c9124b1f7b1eaf64517c5b3fc3f072b
wpt-pr: 24556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants