Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on SensioFrameworkExtraBundle for PSR-7 support on symfony bundle #179

Closed
gambry opened this issue Feb 16, 2021 · 6 comments
Closed
Assignees
Labels
dependencies Pull requests that update a dependency file DX Developer Experience

Comments

@gambry
Copy link

gambry commented Feb 16, 2021

Describe the bug

With Remove PSR-7 support sensio/framework-extra-bundle doesn't have PSR-7 message support from version 6.0.

To Reproduce

Steps to reproduce the behavior:

  1. Require sensio/framework-extra-bundle (either no version, or >= 6.0).
  2. Add the snippet below, as per official guide:
sensio_framework_extra:
    psr_message:
        enabled: true
  1. Do anything, i.e. clear the cache or open a web page.
  2. See error: Unrecognized option "psr_message" under "sensio_framework_extra". Available options are "cache", "request", "router", "security", "templating", "view"

Expected behavior
The symfony app is working as expected

@gambry
Copy link
Author

gambry commented Feb 16, 2021

Projects have started moving to other bundles, see trikoder/oauth2-bundle#261 for example moving to ajgarlag/psr-http-message-bundle.

@Spomky
Copy link
Contributor

Spomky commented Feb 16, 2021

Hi @gambry,

Actually this bundle was something I wanted to integrate to the Webauthn bundle.
I am not in favor of adding a new bundle in replacement to the previous one as it may break some applications.

@Spomky Spomky self-assigned this Feb 16, 2021
@Spomky Spomky added dependencies Pull requests that update a dependency file DX Developer Experience labels Feb 16, 2021
@gambry
Copy link
Author

gambry commented Mar 27, 2021

🤔 it would be nice to collaboratively work on a single replacement, but I also agree with you about adding a new bundle could break things.

I may be able to help on this. I've never played with PSR-7 myself, but I'm happy to give it a try.
How do you want to proceed? Do you want to create a bundle within this framework or add PSR-7 support as part of web-auth/webauthn-symfony-bundle?

@Spomky
Copy link
Contributor

Spomky commented Apr 16, 2021

Hi,

I close this issue as it is now part of the new branch v4.0 (not stable yet).
Thank you for pointing this out.

@Spomky Spomky closed this as completed Apr 16, 2021
@Spomky
Copy link
Contributor

Spomky commented May 2, 2021

THis will also be backported to v3.3

@github-actions
Copy link
Contributor

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file DX Developer Experience
Projects
None yet
Development

No branches or pull requests

2 participants