Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further secure TLS communications #242

Open
saroshali-dbx opened this issue Jun 6, 2022 · 1 comment
Open

Further secure TLS communications #242

saroshali-dbx opened this issue Jun 6, 2022 · 1 comment

Comments

@saroshali-dbx
Copy link

saroshali-dbx commented Jun 6, 2022

Currently when using TLS, the servers will accept requests from any client that has a certificate signed by the specified Certificate Authority. As such, I'd like to see custom server certificate validation supported. This will help enforce deny-by-default.

I'd like to be able to pass a flag, such as -cert-allowed-cn, that can be used to create a custom VerifyPeerCertificate (part of the crypto/tls package) and can be passed as a callback directly to the tls config. All this function needs to do is verify that the seen common-name is the same as the expected common-name.

Willing to submit a PR if the maintainers think this is a good idea. Thanks!

@bboreham
Copy link
Collaborator

bboreham commented Jul 4, 2022

Thanks, I see you opened a PR in the upstream Prom library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants