Add cipher cost option #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdee
requested changes
Sep 21, 2022
encryptor.go
Outdated
| // the default value of 18 (ie. 2^18=262144). Higher values increases the | ||
| // cost of an exhaustive search but makes encoding and decoding proportionally slower. | ||
| // This should only be in testing as it affects security. | ||
| func WithCost(_ *testing.T, costPower uint) Option { |
There was a problem hiding this comment.
I think we should check to confirm that t is not nil, and panic if it is nil. Although I'm not a fan of panicking in general, this is one of those situations where it makes sense.
mcdee
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option to override the cipher cost. Useful to speed up tests that create a lot of keystores.