Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Wrong index bound check in __context() #260

Closed
bolt-juri-gavshin opened this issue Oct 7, 2019 · 2 comments
Closed

Wrong index bound check in __context() #260

bolt-juri-gavshin opened this issue Oct 7, 2019 · 2 comments

Comments

@bolt-juri-gavshin
Copy link

( columns.length >= this.state.record.length ?

columns.length >= this.state.record.length ?
          columns[this.state.record.length].name :
          null

should be replaced with

columns.length > this.state.record.length ?
          columns[this.state.record.length].name :
          null
@wdavidw
Copy link
Member

wdavidw commented Oct 7, 2019

do you have a sample with you so that I can move on quickly by integrating it into our tests?

@bolt-juri-gavshin
Copy link
Author

bolt-juri-gavshin commented Oct 9, 2019

I'm afraid the data is from our private repo.
But looking at the code, you just need a document which has more columns than there are in the options object.
I can try to create a working code/test example tomorrow and add it here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants