Use event.composedPath for getting event target (keydown shadow DOM fix) #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I didn't know about this. I will have a look. |
|
released in v10.3.17 |
|
@moklick would you be up to release this fix in v9 as well if I prepare a ported PR for that? Our team is currently on v9 and it would be great if we didn't have to patch this ourselves locally |
|
We don't do fixes for v9. v10 was released six month ago and we are moving to v11 next week. Can't you upgrade to v10 or better v11 ? |
|
It's in the pipeline but not sure how much longer it'll take. Anyway, we can leave without it for now and hopefully can migrate sooner than we need this functionality. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem where keystrokes are not being registered when originating from shadow DOM inputs. Current react-flow implementation attaches a global event listener for
keydownevent and callspreventDefault()on it if the following 2 conditions are met:deleteKeyCode,multiSelectionKeyCodeetc.)isInputDOMNodereturns trueThis article explains why the current implementation of
isInputDOMNodedoesn't work as well as shows a solution which is used in this PRReproducible demo sandbox: https://codesandbox.io/s/react-flow-with-shadow-dom-lymfwm?file=/index.js