Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Notify 5.pre.16 #382

Closed
Type1J opened this issue Aug 23, 2022 · 2 comments · Fixed by #384
Closed

Update to Notify 5.pre.16 #382

Type1J opened this issue Aug 23, 2022 · 2 comments · Fixed by #384
Labels
bug Something's not right!

Comments

@Type1J
Copy link

Type1J commented Aug 23, 2022

watchexec version 2.0.0
Windows (and Windows WSL2)

This issue in notify: notify-rs/notify#359 causes watchexec to panic when a watched file is removed, then recreated.

The issue can be reproduced by mv watched_file.txt watched_file.txt.bak && mv watched_file.txt.bak watched_file.txt.

Please update to the version with the fix in place.
@Type1J Type1J added the bug Something's not right! label Aug 23, 2022
@passcod passcod changed the title When a watched file is removed, an internal thread panics, and no longer sends messages on event or error channels. Update to Notify 5.pre.16 Aug 24, 2022
@passcod
Copy link
Member

passcod commented Aug 24, 2022

Thanks for patching the upstream! I'll get a release with pre.16 going

passcod added a commit that referenced this issue Aug 24, 2022
@passcod
Update Notify to pre.16 (fixes #382)
71dc9b3
@passcod passcod mentioned this issue Aug 24, 2022
Merged
bors bot pushed a commit that referenced this issue Aug 24, 2022
@passcod
Update Notify to pre.16 (#384)
376eb9f 
Fixes #382
bors bot pushed a commit that referenced this issue Aug 24, 2022
@passcod
Update Notify to pre.16 (#384)
18dc0fc 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Aug 24, 2022
@passcod
Update Notify to pre.16 (#384)
8e0cdc7 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Aug 25, 2022
@passcod
Update Notify to pre.16 (#384)
93501c6 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Aug 25, 2022
@passcod
Update Notify to pre.16 (#384)
b7764a9 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Aug 28, 2022
@passcod
Update Notify to pre.16 (#384)
ac747ee 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Sep 2, 2022
@passcod
Update Notify to stable (#384)
7a9efc8 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
bors bot pushed a commit that referenced this issue Sep 2, 2022
@passcod
Update Notify to stable (#384)
8ddfb13 
Fixes #382

Pushes the MSRV to 1.60, which will incur a minor version bump on a bunch of crates (not the CLI).
This was referenced Sep 7, 2022
Closed
Merged
@passcod
Copy link
Member

passcod commented Sep 7, 2022

Sorry it took so long! This is released in 1.20.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something's not right!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Notify to stable watchexec/watchexec
2 participants
@passcod @Type1J