Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible soundness issue in ChildImp::wait #20

Open
gigaroby opened this issue Sep 7, 2023 · 1 comment
Open

Possible soundness issue in ChildImp::wait #20

gigaroby opened this issue Sep 7, 2023 · 1 comment

Comments

@gigaroby
Copy link

gigaroby commented Sep 7, 2023

While conducting an internal unsafe review, we identified a possible soundness issue in ChildImp::wait

pub async fn wait(&mut self) -> Result<ExitStatus> {
let handles = self.handles.clone();
spawn_blocking(|| Self::wait_imp(handles, INFINITE)).await??;
self.inner.wait().await
}

This function and the one below call the Clone impl that appears to undermine the unsafe Drop impl on self.handles.

@passcod
Copy link
Member

passcod commented Sep 7, 2023

This is the same root issue as the other one you just opened, yeah?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants