Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid opening files when not needed in WASI, check for write permissions #449

Merged
merged 2 commits into from May 15, 2019

Conversation

MarkMcCaskey
Copy link
Contributor

resolves #438

Follow up to #448. Turns out we don't have to complect things in that way, we can just be more conservative about opening files and granting write permissions

@MarkMcCaskey MarkMcCaskey added the 📦 lib-wasi About wasmer-wasi label May 15, 2019
@MarkMcCaskey
Copy link
Contributor Author

bors r+

bors bot added a commit that referenced this pull request May 15, 2019
449: avoid opening files when not needed in WASI, check for write permissions r=MarkMcCaskey a=MarkMcCaskey

resolves #438 

Follow up to  #448.  Turns out we don't have to complect things in that way, we can just be more conservative about opening files and granting write permissions

Co-authored-by: Mark McCaskey <mark@wasmer.io>
@bors
Copy link
Contributor

bors bot commented May 15, 2019

@bors bors bot merged commit 83deae8 into master May 15, 2019
@bors bors bot deleted the fix/wasi-fs-rw-opening branch May 15, 2019 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 lib-wasi About wasmer-wasi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Likely unnecessary write access to a file
2 participants