Fix Singlepass f32_load and f64_load function, and introduce emit_bond_label_far as direct bcond may not work all the time (for #2777) #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ond_label_far as direct bcond may not work all the time (for #2777)
ptitSeb
changed the title
|
I'm a bit concerned about the performance, but <5% seems acceptable for now. bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Aarch64 singlepass fix for #2777 :
emit_bcond_label_faremitter to alow use of bcond on "farther" reloc. It does slow down a little bit (like less than 5% on less powerfull devices), but it's cecessary to be able to run larger wasm file. Also, beeing "singlepass", no real smart way alay to detect if a "far" version is needed or not (so "far" are used everywhere).