Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not compute the hash of wasm modules inside of WebC #4609

Closed
syrusakbary opened this issue Apr 25, 2024 — with Linear · 0 comments
Closed

We should not compute the hash of wasm modules inside of WebC #4609

syrusakbary opened this issue Apr 25, 2024 — with Linear · 0 comments

Comments

Copy link
Member

In a WebC file, there are wasm atoms.

Wasmer should not compute the hash for the wasm atoms, as those are precomputed and already available in the manifest itself.

The atom signature are computed in webc and added in the manifest here: https://github.com/wasmerio/pirita/blob/main/crates/webc/src/wasmer_package/manifest.rs#L198

In the runtime, we need to use those hashes instead of computing them again.

(wasmer run python/python computes the hashes of the python.wasm each time, we can avoid this easily)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant