Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remote code loading framework. #416

Merged
merged 46 commits into from May 16, 2019
Merged

Remote code loading framework. #416

merged 46 commits into from May 16, 2019

Conversation

losfair
Copy link
Contributor

@losfair losfair commented May 2, 2019

No description provided.

@bjfish
Copy link
Contributor

bjfish commented May 8, 2019 •
edited

It would be nice to have a README.md in lib/kwasm to explain the library and how to build and run the examples.

Also, could we add some unit or integration tests for the new functionality?

bjfish
bjfish reviewed May 8, 2019
View reviewed changes
lib/runtime-core/src/backing.rs
if imports.allow_missing_functions {
functions.push(vm::ImportedFunc {
func: ::std::ptr::null(),
vmctx: ::std::ptr::null_mut(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could mock missing imports again (which is a separate feature though). We used to mock imports and just print a message like "mock import func_test called".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the currently implementation the program receives a SIGSEGV when a null imported function is called, which I think is fine for now.

The import mocking feature can be added in a separate PR.

@losfair
Copy link
Contributor Author

losfair commented May 15, 2019

bors try

bors bot added a commit that referenced this pull request May 15, 2019
@bors
Try #416:
0109bd9
@bors
Copy link
Contributor

bors bot commented May 15, 2019

try

Build failed

@losfair
Copy link
Contributor Author

losfair commented May 15, 2019

bors try

bors bot added a commit that referenced this pull request May 15, 2019
@bors
Try #416:
d4b3b72
@bors
Copy link
Contributor

bors bot commented May 15, 2019

try

Build succeeded

@syrusakbary
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 15, 2019
@bors
Try #416:
04d232b
@bors
Copy link
Contributor

bors bot commented May 15, 2019

try

Build succeeded

@losfair
Copy link
Contributor Author

losfair commented May 16, 2019

bors try

bors bot added a commit that referenced this pull request May 16, 2019
@bors
Try #416:
015cf3b
@losfair
Copy link
Contributor Author

losfair commented May 16, 2019

bors r+

bors bot added a commit that referenced this pull request May 16, 2019
@bors @losfair
Merge #416
ddcc6df 
416: Remote code loading framework. r=losfair a=losfair



Co-authored-by: losfair <zhy20000919@hotmail.com>
Co-authored-by: Heyang Zhou <zhy20000919@hotmail.com>
@bors
Copy link
Contributor

bors bot commented May 16, 2019

Timed out

@bors
Copy link
Contributor

bors bot commented May 16, 2019

try

Build succeeded

@losfair
Copy link
Contributor Author

losfair commented May 16, 2019

bors r+

bors bot added a commit that referenced this pull request May 16, 2019
@bors @losfair
Merge #416
4e5ac24 
416: Remote code loading framework. r=losfair a=losfair



Co-authored-by: losfair <zhy20000919@hotmail.com>
Co-authored-by: Heyang Zhou <zhy20000919@hotmail.com>
@bors
Copy link
Contributor

bors bot commented May 16, 2019

Build succeeded

@bors bors bot merged commit 100039a into master May 16, 2019
@bors bors bot deleted the feature/remote-code-load branch May 16, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjfish bjfish bjfish left review comments

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@losfair @bjfish @syrusakbary