From e188807a79d67d1a749666619291871ad8bb7143 Mon Sep 17 00:00:00 2001 From: Amanieu d'Antras Date: Tue, 18 Jan 2022 12:28:33 +0000 Subject: [PATCH] Try to enable some tests --- lib/engine-dylib/src/artifact.rs | 4 ++-- tests/ignores.txt | 6 ------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/engine-dylib/src/artifact.rs b/lib/engine-dylib/src/artifact.rs index 4f82093f3fd..7165b4b1bb8 100644 --- a/lib/engine-dylib/src/artifact.rs +++ b/lib/engine-dylib/src/artifact.rs @@ -244,7 +244,7 @@ impl DylibArtifact { get_object_for_target(&target_triple).map_err(to_compile_error)?; emit_trampolines(&mut obj, engine.target()); if obj.format() == BinaryFormat::Coff { - obj.add_coff_exports(CoffExportStyle::Msvc); + obj.add_coff_exports(CoffExportStyle::Gnu); } let file = tempfile::Builder::new() .prefix("wasmer_dylib_") @@ -291,7 +291,7 @@ impl DylibArtifact { emit_compilation(&mut obj, compilation, &symbol_registry, &target_triple) .map_err(to_compile_error)?; if obj.format() == BinaryFormat::Coff { - obj.add_coff_exports(CoffExportStyle::Msvc); + obj.add_coff_exports(CoffExportStyle::Gnu); } let file = tempfile::Builder::new() .prefix("wasmer_dylib_") diff --git a/tests/ignores.txt b/tests/ignores.txt index 7f72118a661..274020d2ce4 100644 --- a/tests/ignores.txt +++ b/tests/ignores.txt @@ -3,7 +3,6 @@ singlepass spec::multi_value # Singlepass has not implemented multivalue (functi singlepass spec::simd # Singlepass doesn't support yet SIMD (no one asked for this feature) singlepass+dylib * # It needs to add support for PIC in Singlepass. Not implemented at the moment -windows+dylib * # This might be trivial to fix? musl+dylib * # Dynamic loading not supported in Musl # Traps @@ -33,14 +32,9 @@ llvm traps::start_trap_pretty dylib traps::start_trap_pretty aarch64 traps::start_trap_pretty -cranelift multi_value_imports::dylib # Needs investigation singlepass multi_value_imports::dylib # Singlepass doesn't support multivalue singlepass multi_value_imports::dynamic # Singlepass doesn't support multivalue -# LLVM doesn't fully work in macOS M1 -llvm+universal+macos+aarch64 * # We are using the object crate, it was not fully supporting aarch64 relocations emitted by LLVM. Needs reassesment -llvm+dylib+macos+aarch64 * # Tests seem to be randomly failing - # TODO: We need to fix this in ARM. The issue is caused by libunwind overflowing # the stack while creating the stacktrace. # https://github.com/rust-lang/backtrace-rs/issues/356