Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to compile on mbedtls 3.6+ #3127

Open
orangepizza opened this issue May 3, 2024 · 1 comment
Open

unable to compile on mbedtls 3.6+ #3127

orangepizza opened this issue May 3, 2024 · 1 comment

Comments

@orangepizza
Copy link
Contributor

mbedtls_x509_get_name become unexposed in mbedtls 3.6, make it blocking compile
made a temp fix by redeclare moved function in a file, but will need actual alternative implementation where it actually used
openwrt/packages#24071

@dddaniel
Copy link

dddaniel commented May 6, 2024

Can confirm. Won't build without -DDISABLE_WERROR=ON

[ 30%] Building C object lib/CMakeFiles/websockets_shared.dir/tls/mbedtls/mbedtls-client.c.o [ 30%] Building C object lib/CMakeFiles/websockets.dir/tls/mbedtls/mbedtls-server.c.o /home/daniel/srcs/libwebsockets/lib/tls/mbedtls/mbedtls-extensions.c: In function ‘lws_mbedtls_x509_parse_general_name’: /home/daniel/srcs/libwebsockets/lib/tls/mbedtls/mbedtls-extensions.c:253:23: warning: implicit declaration of function ‘mbedtls_x509_get_name’; did you mean ‘mbedtls_pk_get_name’? [-Wimplicit-function-declaration] 253 | ret = mbedtls_x509_get_name( p, end, &rfc822Name ); | ^~~~~~~~~~~~~~~~~~~~~ | mbedtls_pk_get_name [ 31%] Building C object lib/CMakeFiles/websockets.dir/tls/tls-client.c.o [ 31%] Building C object lib/CMakeFiles/websockets.dir/tls/mbedtls/mbedtls-client.c.o [ 31%] Building C object lib/CMakeFiles/websockets_shared.dir/core/alloc.c.o /home/daniel/srcs/libwebsockets/lib/tls/mbedtls/mbedtls-extensions.c: In function ‘lws_mbedtls_x509_parse_general_name’: /home/daniel/srcs/libwebsockets/lib/tls/mbedtls/mbedtls-extensions.c:253:23: warning: implicit declaration of function ‘mbedtls_x509_get_name’; did you mean ‘mbedtls_pk_get_name’? [-Wimplicit-function-declaration] 253 | ret = mbedtls_x509_get_name( p, end, &rfc822Name ); | ^~~~~~~~~~~~~~~~~~~~~ | mbedtls_pk_get_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants