Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h2: client: send the :authority header #3105

Open
baltitenger opened this issue Apr 4, 2024 · 1 comment
Open

h2: client: send the :authority header #3105

baltitenger opened this issue Apr 4, 2024 · 1 comment

Comments

@baltitenger
Copy link

According to rfc7540 the :authority pseudo-header field should be used instead of the Host header field. I need this change because I want to interact with a server that rejects requests sent by the current version of libwebsockets since it only sends the Host header. Note that in case of HTTP/2, libcurl only sends :authority, as recommended by the rfc. I see that libwebsockets also used to do this but that part of the code has been changed in lib/roles/http2.c. Is this change still required / intentional?

@lws-team
Copy link
Member

Honestly I don't remember. git blame says it was done while handling h2 redirects using the same client wsi, I assume it made trouble there, perhaps due to the authority needing changing then?

If you want to resurrect it with something that works, I'll be happy to look at a patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants