Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compression of assets optional #83

Merged
merged 1 commit into from Jun 13, 2022

Conversation

bcrochet
Copy link

Signed-off-by: Brad P. Crochet brad@redhat.com

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@@ -84,6 +84,11 @@ inputs:
required: false
default: ''

compress_assets:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think provide several options for this would be better:

  • auto: current behavior
  • off: disable
  • zip: all use zip for the compression, including Linux
    Maybe other compression methods in the future.

How's your option?

Copy link
Contributor

@Zxilly Zxilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Hope for merge.

@wangyoucao577 wangyoucao577 merged commit c0c0c91 into wangyoucao577:master Jun 13, 2022
@wangyoucao577
Copy link
Owner

Merged, since more than three people think it's valuable. Thanks!

@wangyoucao577
Copy link
Owner

Now new version for you guys wangyoucao577/go-release-action@v1.29. Thanks very much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants