From 88600ddf8bd9d48d8ba00d482cabadc5d348e2dc Mon Sep 17 00:00:00 2001 From: Kyle Goyette Date: Thu, 27 Oct 2022 09:34:28 -0700 Subject: [PATCH 1/5] wip --- wandb/apis/public.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/wandb/apis/public.py b/wandb/apis/public.py index f5e8fee5eed..f52043f24e8 100644 --- a/wandb/apis/public.py +++ b/wandb/apis/public.py @@ -5198,7 +5198,7 @@ def _configure_launch_project_repo(self, launch_project): launch_project.add_entry_point(self._entrypoint) launch_project.python_version = self._source_info.get("runtime") if self._args: - launch_project.override_args = self._args + launch_project.override_args = util._user_args_to_dict(self._args) def _configure_launch_project_artifact(self, launch_project): artifact_string = self._source_info.get("source", {}).get("artifact") @@ -5216,7 +5216,7 @@ def _configure_launch_project_artifact(self, launch_project): launch_project.add_entry_point(self._entrypoint) launch_project.python_version = self._source_info.get("runtime") if self._args: - launch_project.override_args = self._args + launch_project.override_args = util._user_args_to_dict(self._args) def _configure_launch_project_container(self, launch_project): launch_project.docker_image = self._source_info.get("source", {}).get("image") @@ -5227,7 +5227,7 @@ def _configure_launch_project_container(self, launch_project): if self._entrypoint: launch_project.add_entry_point(self._entrypoint) if self._args: - launch_project.override_args = self._args + launch_project.override_args = util._user_args_to_dict(self._args) def set_entrypoint(self, entrypoint: List[str]): self._entrypoint = entrypoint From 3eb1736fadd981c57e9e30a245273d893e7e5674 Mon Sep 17 00:00:00 2001 From: Kyle Goyette Date: Thu, 27 Oct 2022 09:56:23 -0700 Subject: [PATCH 2/5] update test --- tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py index b29fd363de5..f00046348d9 100644 --- a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py +++ b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py @@ -59,4 +59,4 @@ ) assert "requirements.frozen.txt" in os.listdir(lp.project_dir) print(command) -assert lp.override_args == ["--log-test"] +assert lp.override_args == {"--log-test": True} From 08b5fac4d22192ecf0c4d54a432b4fa20944c971 Mon Sep 17 00:00:00 2001 From: Kyle Goyette Date: Thu, 27 Oct 2022 10:28:42 -0700 Subject: [PATCH 3/5] update --- tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py index f00046348d9..18c1027c4c3 100644 --- a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py +++ b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py @@ -59,4 +59,5 @@ ) assert "requirements.frozen.txt" in os.listdir(lp.project_dir) print(command) -assert lp.override_args == {"--log-test": True} +print(lp.override_args) +assert lp.override_args["--log-test"] == True From 8e1a7da244836e7f828d211d001c68d286033c1a Mon Sep 17 00:00:00 2001 From: Kyle Goyette Date: Thu, 27 Oct 2022 10:53:17 -0700 Subject: [PATCH 4/5] wip --- tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py index 18c1027c4c3..c9148042f95 100644 --- a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py +++ b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py @@ -60,4 +60,4 @@ assert "requirements.frozen.txt" in os.listdir(lp.project_dir) print(command) print(lp.override_args) -assert lp.override_args["--log-test"] == True +assert lp.override_args["--log-test"] is True From bbe72637a83352b8bca409205995e15440a94ae8 Mon Sep 17 00:00:00 2001 From: Kyle Goyette Date: Mon, 7 Nov 2022 12:18:30 -0800 Subject: [PATCH 5/5] fix test --- tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py index c9148042f95..148e87b8b4c 100644 --- a/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py +++ b/tests/functional_tests/t0_main/jobs/job_repo_end_to_end.py @@ -60,4 +60,4 @@ assert "requirements.frozen.txt" in os.listdir(lp.project_dir) print(command) print(lp.override_args) -assert lp.override_args["--log-test"] is True +assert lp.override_args["log-test"] is True