New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(sdk): remove dependency on six by modifying vendored libs #4280
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4280 +/- ##
==========================================
+ Coverage 83.07% 83.12% +0.04%
==========================================
Files 267 267
Lines 33739 33739
==========================================
+ Hits 28030 28046 +16
+ Misses 5709 5693 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think updating the wandb-vendor.md files (3 of them) with the procedure mentioned in the PR (or one line summary of it so people can find the change from the PR), and optionally a separate diff for the pyupgrade stuff (rather than merging them into one diff) makes sense to me.
The diff is bonus... the main thing we want to know is the steps done on the base vendored code so we can reproduce them if needed.. technically the diff can be found in git so if it isnt totally necessary.
also need to resolve the conflict from the watchdog prefix vendor that just went in.
@raubitsj cleaned this up and addressed your comment (mainly, rm'ed all the non-six-relevant pyupgrade stuff). |
Fixes WB-NNNN
Fixes #NNNN
Description
This PR removes dependency on
six
by modifying vendored libsgql
andgraphql-core
.Concretely what I did was:
git grep " six"
(to catchimport six
andfrom six import ...
)pyupgrade --py36-plus <filename>
on each identified file and manually made sure the result was good.git diff > wandb-vendor.diff
, ensured they looked goodTesting
CI!
Checklist