Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and extend NL locale + add test for all #373

Merged
merged 20 commits into from
Feb 15, 2021
Merged

Conversation

JeroenVdb
Copy link
Contributor

I wanted to use this library for the nl locale, which was added via PR #351. I noticed some parsers where not correct and/or incomplete and missing tests.

Changed/fixed

  • Fixed NLMonthNameMiddleEndianParser: "januari 13, 2012" -> "13 januari 2012"

Added:

  • Tests for all nl parsers and refiners
  • Added NLCasualDateTimeParser for combined words like "morgennamiddag", "vanavond" and "gisterenochtend"
  • Added NLCasualYearMonthDayParser for YMD pattern support

@JeroenVdb
Copy link
Contributor Author

JeroenVdb commented Feb 3, 2021

@Pruxis maybe you should also check these changes as you added the original nl implementation.
I think the biggest (breaking) change is the format fix in NLMonthNameMiddleEndianParser.ts - but in my opinion the old format (January 13, 2012) was just wrong.

@JeroenVdb
Copy link
Contributor Author

JeroenVdb commented Feb 3, 2021

Same for @Thymo as you added the implementation in version 1: #324

@wanasit
Copy link
Owner

wanasit commented Feb 15, 2021

Wow! Thanks for the improvement!
Sorry for my slow reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants