Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research and possibly implement using KEYWORDS as dependencies when found in Html files #203

Open
alanhamlett opened this issue Jan 5, 2021 · 2 comments

Comments

@alanhamlett
Copy link
Member

alanhamlett commented Jan 5, 2021

The Python cli used to look for keywords, such as ember or backbone, in Html files and assume those keywords being present means the associated JavaScript library was being included on the page with a script tag. It would then use the found keyword as a dependency, adding it to the list of detected dependencies for the current heartbeat:

wakatime/legacy-python-cli@166f418#diff-e99152f6ea6bc64e5a34bf5cebaed10862f3abec05aa3528fa8ff8ed892b37ecR88

Sometime after launching 1.0, let's research if this is still needed, if it was replaced with another detection method, and if we should add it back to wakatime-cli's Html parser.

More info in Slack: https://wakatime.slack.com/archives/GUWD67UE4/p1609032466002300

Related to #148.

@gandarez gandarez added this to To do in wakatime-cli via automation Jan 10, 2021
@gandarez gandarez added this to the v0.2.0 milestone Mar 5, 2021
@dron22 dron22 moved this from To do to Backlog in wakatime-cli Apr 17, 2021
@gandarez
Copy link
Member

gandarez commented Sep 14, 2023

@alanhamlett the link to the commit is broken. Do you know where it's implemented?

@alanhamlett
Copy link
Member Author

Fixed the link to the commit.

@gandarez gandarez removed this from the v0.2.0 milestone Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
wakatime-cli
  
Backlog
Development

No branches or pull requests

2 participants