Prevent error on page editing after changing LANGUAGE_CODE #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manage this branch in SquashTest this branch here: https://gasmanfixpage-edit-after-chang-52iup.squash.io |
kaedroho
approved these changes
Mar 5, 2021
There was a problem hiding this comment.
This looks good to me, thanks for fixing it!
The reason I added this was to remove invalid locales from all the menus. But it's probably better to display the broken locales in the menus as this would make it easier to tell what's going on and the logic is simpler!
gasman
added a commit
that referenced
this pull request
Mar 5, 2021
gasman
added a commit
that referenced
this pull request
Mar 5, 2021
gasman
added a commit
that referenced
this pull request
Mar 5, 2021
gasman
added a commit
that referenced
this pull request
Mar 5, 2021
gasman
added a commit
that referenced
this pull request
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6860 as per #6860 (comment).