Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when copying an alias page #6854

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Fix crash when copying an alias page #6854

merged 1 commit into from
Mar 3, 2021

Conversation

kaedroho
Copy link
Contributor

@kaedroho kaedroho commented Mar 1, 2021 •
edited

Fixes #6758

This sets alias_of to null on all copied pages. So if someone copies an alias page, the new page will not be an alias.

@squash-labs
Copy link

squash-labs bot commented Mar 1, 2021

Manage this branch in Squash

Test this branch here: https://kaedrohofix-alias-copy-crash-y5l8e.squash.io

@kaedroho kaedroho requested a review from gasman March 1, 2021 17:35
jacobtoppm
jacobtoppm approved these changes Mar 2, 2021
View reviewed changes
Copy link
Member

@jacobtoppm jacobtoppm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaedroho kaedroho merged commit aad0d0b into wagtail:master Mar 3, 2021
@kaedroho kaedroho deleted the fix-alias-copy-crash branch March 3, 2021 10:15
@kaedroho
Copy link
Contributor Author

kaedroho commented Mar 3, 2021

Thanks!

@gasman gasman added this to the 2.11.6 milestone Mar 3, 2021
@gasman
Copy link
Collaborator

gasman commented Mar 3, 2021

Tagging for the next 2.11 (and 2.12) patch release, as this sounds like one that ought to be backported (unless I hear otherwise).

@kaedroho
Copy link
Contributor Author

kaedroho commented Mar 4, 2021

Yep, I didn't realise there was going to be another 2.11 release, but I've already put it on the 2.12 branch!

gasman added a commit that referenced this pull request Mar 4, 2021
@gasman
Release note for #6854 in 2.11.6
92bd561
gasman added a commit that referenced this pull request Mar 4, 2021
@gasman
Release note for #6854 in 2.11.6
110709a
gasman added a commit that referenced this pull request Mar 4, 2021
@gasman
Release note for #6854 in 2.12.3
c4ba157
gasman added a commit that referenced this pull request Mar 4, 2021
@gasman
Release note for #6854 in 2.11.6
a570563
gasman added a commit that referenced this pull request Mar 4, 2021
@gasman
Release note for #6854 in 2.12.3
9ed99c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobtoppm jacobtoppm jacobtoppm approved these changes

@gasman gasman Awaiting requested review from gasman

Assignees
No one assigned
Labels
type:Bug
Projects
None yet
Milestone
2.11.6
Development

Successfully merging this pull request may close these issues.

Crash when copying alias pages
3 participants
@kaedroho @gasman @jacobtoppm