Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release process #285

Open
laymonage opened this issue Mar 1, 2024 · 1 comment · May be fixed by #286
Open

Automate release process #285

laymonage opened this issue Mar 1, 2024 · 1 comment · May be fixed by #286
Assignees

Comments

@laymonage
Copy link
Member

laymonage commented Mar 1, 2024

Noticed a few things when I was releasing v6.3.0 just now:

  • Our git tags are inconsistent: some start with v, some don't: https://github.com/wagtail/sphinx-wagtail-theme/tags
  • In the release process guide, there are prerelease and postrelease commands that I don't know where they come from. They do not seem to be necessary.
  • The python -m build command doesn't seem correct. It should be python setup.py sdist bdist_wheel or make build.
  • The requirements.txt does not include wheel and twine, so these had to be installed separately. Either include them in the requirements.txt, or call this out explicitly.

That said, it would be nice to automate the release process using GitHub Actions. We already build the project in our CI config, we can add additional step that publishes the package using the official PyPI action and the Trusted Publisher configuration. I use this for modeladmin and it's working great: https://github.com/wagtail-nest/wagtail-modeladmin/blob/main/.github/workflows/publish.yml.

cc @Stormheg

@Stormheg Stormheg self-assigned this Mar 2, 2024
@lb-
Copy link
Member

lb- commented Mar 4, 2024

I agree about the pre/postrelease - I have no idea where that comes from. It worked on my old laptop but not on my new one and in the last release I just manually created the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants