Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search broken due to JavaScript "undefined" #274

Open
vsalvino opened this issue Nov 15, 2023 · 4 comments · May be fixed by #291
Open

Search broken due to JavaScript "undefined" #274

vsalvino opened this issue Nov 15, 2023 · 4 comments · May be fixed by #291
Labels
bug Something isn't working

Comments

@vsalvino
Copy link
Contributor

At some point, the search has been broken (the built-in search, not algolia from the wagtail docs).

It is injecting "undefined" into the URLs when jumping to a specific page.

I'll investigate later whether this is due to a sphinx change or a JS change in our theme.

Example: https://docs.coderedcorp.com/wagtail-crx/index.html

  • Search for "Contributing", select the suggested "Contributing" page (click or press enter).
  • The page 404s. The URL contains an "undefined" which is causing the breakage.
    # Search URL
    https://docs.coderedcorp.com/wagtail-crx/undefinedcontributing/index.html
    
    # Real URL
    https://docs.coderedcorp.com/wagtail-crx/contributing/index.html
    

image

@lb-
Copy link
Member

lb- commented Nov 20, 2023

It does not seem to happen on the deployed version here https://sphinx-wagtail-theme.readthedocs.io/

@chintanp
Copy link

chintanp commented Apr 8, 2024

@vsalvino were you able to resolve this? I am facing the same issue,

@vsalvino
Copy link
Contributor Author

The deployed version was not using the latest version. It seems to have been recently deployed and now is exhibiting the issue.

image

@vsalvino
Copy link
Contributor Author

Did a bit more digging... turns out this broke due to a change in Sphinx 7.2. I'm still tracing down the fix, but as a workaround, build with sphinx<7.2

@vsalvino vsalvino linked a pull request May 30, 2024 that will close this issue
@vsalvino vsalvino added the bug Something isn't working label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants