-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated layout to adjust width on xl screens #232
Updated layout to adjust width on xl screens #232
Conversation
Hi Theresa, Could you please provide some before and after screenshots? |
Ok, let me do that now. Thanks. |
Yes, that is what I was wanting to see, thank you! I'm afraid that your change doesn't seem to be addressing the crux of the issue, though. The space being present is not the problem itself. The real problem is that the page-level table of contents (the right sidebar) can sometimes have a horizontal (left-right) scrollbar, as noted in the original issue:
If you load the page in the original issue screenshot, you can see this horizontal scrolling. Adding with to the main content column will not fix that – in fact, it is probably already too wide with respect to best practices for readable line lengths – we just want to eliminate those horizontal scrollbars. That said, the horizontal scrollbars should not be there, regardless of the browser width. Try reducing your browser width to a size where the text will wrap to see this. (I see it at 1920px wide.) The text in the page TOC will wrap, and yet the scrollbars are still present, so adding width to the page TOC column will probably not solve the issue, either. @Theresa-o, could you try to diagnose the root cause of the horizontal scrolling and fix that? |
Ok, I would confirm this and provide update
|
See also @Scotchester some improvements to the horizontal scrollbar issue in #215 (essentially forcing the content to wrap instead of adding scrollbars. |
@Scotchester @lb- The horizontal scrollbar is still persistent because currently the default state is overriding 'overflow-x: hidden' so when inspecting the page 'overflow-x: hidden' is not showing as seen in the below image As a result, we would need to bulldoze through specificity and use !important to ensure that the browser implements this. I'd like to make a PR with the following code changes, please let me know your thoughts/suggestions .page-toc { //old code Please see screenshot of the effect of the updated code below; |
@Theresa-o My sincere apologies – I overlooked the fact that the horizontal scrollbar problem I was talking about was already fixed in PR #215 that @lb- mentioned. This solves the most acute symptom described in issue #223 that you were trying to address, but I do think there are still some improvements to be gained in how our columns lay out over the range of screen sizes. I think it is more nuanced than simply widening the main column as you originally proposed in this PR, though. I'm going to close this PR and comment back on #223 with my thoughts on the remaining problems. |
No problem, okay @Scotchester |
Updated layout to adjust width on xl screens
Fixes #223
Adjusted the width for larger screens using bootstrap classes "col-xl-2" "col-xl-2" to remove the extra width