Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

On large screens full width is not used, but page TOC need horizontal scrolling #223

Open
tbrlpld opened this issue Oct 14, 2022 · 5 comments
Labels
good first issue Good for newcomers

Comments

@tbrlpld
Copy link
Collaborator

tbrlpld commented Oct 14, 2022

Screen Shot 2022-10-14 at 15 26 09

The main content container and the page TOC seem to have some limited width set somewhere. This is particularly jarring since it creates horizontal scrolling on the page TOC 馃槵

Maybe we can update this to make better use of the available space.

@lb- lb- added the good first issue Good for newcomers label Oct 18, 2022
@lb-
Copy link
Member

lb- commented Oct 18, 2022

Adding as good first issue.

See also some other similar PRs that aim to ensure the column layouts work better

@Theresa-o
Copy link

Theresa-o commented Oct 22, 2022

@lb- I can confirm that this issue is still pending.
I would work on this and provide feedback.

wagdocslg

Thanks

@Scotchester
Copy link
Contributor

As noted by @lb-, PR #215 addressed the problem of the horizontal scrollbar.

I do think there are some column layout issues we should address, but the presence of some unused space on the right is not the worst of them. In fact, I think we should have more unused space on wide viewports. As it currently stands, our main text column is far too wide for good readability.

IMHO, I would suggest the following:

  • Limit the main column width to just enough that our code snippets would fit a max of 88 characters, which is our Python line length limit. This should naturally result in a decent max width for regular paragraphs. (A quick test suggests a good starting point would be max-width: 53em on the main column.)
  • Widen the left nav column (i.e., give it a max width) that is just large enough to not have any current nav items wrap onto 3 lines.
  • Set the right page TOC column to the same width as the left nav.
  • Move the new word-break: break-all; property on .page-toc to .page-toc code so that it doesn't apply to plain text. (It was really just long code items that were causing the horizontal scrolling.)

@tbrlpld
Copy link
Collaborator Author

tbrlpld commented Nov 17, 2022

Totally agree @Scotchester.

My grief with the whitespace is only that it's there while we also have the Horizont scrolling on the page toc on the right.

But yes, we should have more whitespace on a large viewport like this.

@Scotchester
Copy link
Contributor

Thanks, @tbrlpld, but just to reiterate: The horizontal scrolling has been fixed :) See: https://docs.wagtail.org/en/stable/releases/3.0.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants