Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot find module 'conventional-changelog-conventionalcommits' #552

Closed
BnGyA opened this issue Oct 7, 2022 · 7 comments
Closed

Cannot find module 'conventional-changelog-conventionalcommits' #552

BnGyA opened this issue Oct 7, 2022 · 7 comments

Comments

@BnGyA
Copy link

BnGyA commented Oct 7, 2022

When using the latest version (5.1.2) in the CI we get this error

error running commitlint
Cannot find module 'conventional-changelog-conventionalcommits'

Thanks for your help

@wagoid
Copy link
Owner

wagoid commented Oct 7, 2022

Hi @BenjaminRochez! Could you show me your workflow file? I've tested in another repo and it works fine. I double checked package-lock.json and conventional-changelog-conventionalcommits is there, it's a dependency of @commitlint/config-conventional

@BnGyA
Copy link
Author

BnGyA commented Oct 7, 2022

name: review-branch
on:
  push:
    branches-ignore:
      - master
jobs:
  commitlint:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          fetch-depth: 0
      - uses: wagoid/commitlint-github-action@v5

We tried to pin it to v5.1.2 but it didn't work either. We pinned it to v4.1.15 which does the job.

@wagoid
Copy link
Owner

wagoid commented Oct 7, 2022

Interesting, I wonder why this is failing even with the default setup. Do you have a commitlint config file? If so, what are its contents?

@zapteryx
Copy link

zapteryx commented Oct 8, 2022

hi there @wagoid! started experiencing this too. here's the run: https://github.com/ZPTXDev/Quaver/actions/runs/3200635351/jobs/5246449218

@wagoid
Copy link
Owner

wagoid commented Oct 8, 2022

Thanks for the link @zapteryx! I see now, I'll need to mark it as a dependency too even though it's already a dependency of @commitlint/config-conventional. Will add a fix for it, thanks both!

@wagoid wagoid closed this as completed in b584ba3 Oct 8, 2022
wagoid added a commit that referenced this issue Oct 8, 2022
…changelog-conventionalcommits

fix: add conventional-changelog-conventionalcommits dependency to fix #552
@wagoid
Copy link
Owner

wagoid commented Oct 8, 2022

Done, v5 (5.2.0) should have the fix. Feel free to reopen if this is still an issue 💪

@BnGyA
Copy link
Author

BnGyA commented Oct 8, 2022

Thanks for your help ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants