ci: set workspace directory as safe after checkout #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagoid
force-pushed
the
ci/fix-unsafe-repository-issue
branch
from
dd1460f
to
5dfd1e2
Compare
`actions/checkout` already fixed the issue on their side in [v3.0.1](https://github.com/actions/checkout/releases/tag/v3.0.1). But since this is a container action, it can be run with another uid than the one from `actions/checkout` and therefore we need to add the `safe.directory` config again. Another way of fixing this would be to make this action run with the same uid as the github runner, but as mentioned [here](actions/checkout#760 (comment)) we're not sure whether the `1000` uid of the runner is reliable. The different `uid` issue seems more like a Github Actions ecosystem problem, maybe they'll take care of it later.
wagoid
force-pushed
the
ci/fix-unsafe-repository-issue
branch
from
5dfd1e2
to
ce9a8cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to actions/checkout#760
actions/checkoutalready fixed the issue on their side inv3.0.1.
But since this is a container action, it can be run with another uid than the one
from
actions/checkoutand therefore we need to add thesafe.directoryconfig again.Another way of fixing this would be to make this action run with the same uid as the github runner, but as mentioned here we're not sure whether the
1000uid of the runner is reliable.The different
uidissue seems more like a Github Actions ecosystem problem, maybe they'll take care of it later.