Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(.husky): remove unnecessary .gitignore [skip-ci] #383

Merged
merged 2 commits into from Apr 15, 2022
Merged

chore(.husky): remove unnecessary .gitignore [skip-ci] #383

merged 2 commits into from Apr 15, 2022

Conversation

Fdawgs
Copy link
Contributor

@Fdawgs Fdawgs commented Apr 11, 2022

.husky/.gitignore is no longer required as of husky 7.0.0, and the devDep is currently at ^7.0.4.

Copy link
Collaborator

@jdbruijn jdbruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! To stay in line with the Husky v7 hooks, they should then also source the husky file right after the shebang. So add . "$(dirname "$0")/_/husky.sh" after the shebang line.

https://github.com/typicode/husky/blob/68e26c6675989d15b2c2ce4aca063baebd44e256/src/index.ts#L56-L75

@Fdawgs Fdawgs requested a review from jdbruijn April 15, 2022 13:11
Copy link
Owner

@wagoid wagoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@wagoid wagoid merged commit 534ab20 into wagoid:master Apr 15, 2022
@Fdawgs Fdawgs deleted the chore/husky branch April 15, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants