Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hashing speed #33

Closed
burdges opened this issue May 9, 2019 · 3 comments
Closed

Improve hashing speed #33

burdges opened this issue May 9, 2019 · 3 comments

Comments

@burdges
Copy link
Collaborator

burdges commented May 9, 2019

We almost always use merlin for hashing, but merlin is not optimized for large amounts of data, thus making SigningTranscript::bytes slow. We should look into blake2x and/or develop a chacha based strobe variant and/or encourage using the SigningTranscript::hash256 method instead. See paritytech/substrate#2415

@burdges
Copy link
Collaborator Author

burdges commented May 14, 2019

I've added a warning on the bytes method. We'll add benchmarks eventually and then compare with SimpleTranscript<Shake128> and eventually SimpleTranscript<Blake2x> if RustCrypto/hashes#83 happens.

This was referenced May 14, 2019
@burdges
Copy link
Collaborator Author

burdges commented Jun 22, 2019

Aside from either using Blake2x directly or doing a ChaCha variant of STROBE. We could give Keccak STROBE a fast mode, likely along the lines of KangarooTwelve. See debris/tiny-keccak#41

@burdges
Copy link
Collaborator Author

burdges commented Aug 8, 2019

I'm going to close this since the ship sailed and we're using merlin now. :)

@burdges burdges closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant