Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark "ambient-light-sensor" as behind a flag in features.md #478

Open
o3-steven opened this issue Jul 11, 2022 · 3 comments
Open

Mark "ambient-light-sensor" as behind a flag in features.md #478

o3-steven opened this issue Jul 11, 2022 · 3 comments

Comments

@o3-steven
Copy link

Browser:
Chrome Version 103.0.5060.114

Error:
Error with Permissions-Policy header: Unrecognized feature: 'ambient-light-sensor'.

The above error is shown in the console while in the features document shows it being available in Chrome 66. Reading into the issue on Chromium I suspect that ambient-light-sensor might be covered by the 'accelerometer' permission-policy and there is an item open to decouple them Link

Either way on the feature documentation could we get that cleared up?

@miketaylr
Copy link
Member

"ambient-light-sensor" is supported in Chromium (see https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/permissions_policy/permissions_policy_features.json5;l=60-64?q=ambient-light-sensor%20file:json&start=31) - but will depend on the #enable-generic-sensor-extra-classes flag being enabled in chrome://flags/.

See https://chromestatus.com/feature/5298357018820608.

@o3-steven
Copy link
Author

Hey @miketaylr I guess my initial confusion is due to the fact that other features hidden behind flags are clearly marked in the documentation while this one is not. Would it be possible to update the documentation?

@miketaylr miketaylr changed the title ambient-light-sensor is an unrecognized feature Mark "ambient-light-sensor" as behind a flag in features.md Jul 14, 2022
@miketaylr miketaylr reopened this Jul 14, 2022
@miketaylr
Copy link
Member

@o3-steven ah yeah - that sounds useful. :)

Would you like to send in a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants