Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"ASCII serialization" #115

Open
annevk opened this issue Dec 20, 2017 · 4 comments
Open

"ASCII serialization" #115

annevk opened this issue Dec 20, 2017 · 4 comments

Comments

@annevk
Copy link
Member

annevk commented Dec 20, 2017

It doesn't seem like this section defines a serialization. It defines a header syntax, but not a serialization of some data structure. (I suppose this might get solved to some extent if the shared data model with CSP is sorted, but seemed worth reporting separately.)

@clelland
Copy link
Collaborator

You're right -- I've called them "serialized feature policy" and "serialized policy directive", but they're never really serialized from anything. They're only ever parsed from that representation into the internal data structures.

(CSP appears to do the same thing: I may have been inspired by that spec when I wrote it)

@pabrai pabrai added the eng task label May 8, 2019
@pabrai pabrai added this to Needs triage in FP Issue Triaging May 13, 2019
@clelland clelland moved this from Needs triage to Needs Assignee in FP Issue Triaging Jul 29, 2019
@hober
Copy link
Member

hober commented Dec 5, 2019

(Hi. Got here in a convoluted manner from w3ctag/design-reviews#369.)

It's also weird to call this "ASCII" in the first place, isn't it? I would have expected this to look more like the Infra spec's definition of serialize JSON to bytes.

@clelland
Copy link
Collaborator

clelland commented Dec 6, 2019

Well, it's definitely not a serialization algorithm; the section just defines the textual representation of policy directives, for use in headers and the allow attribute. Maybe the thing to do here is to rename this to something like "text representation", and make it part of the delivery section. Then we'd be rid of the problematic heading that suggests that we're going to serialize something.

Would that make sense to you?

@annevk
Copy link
Member Author

annevk commented Jan 13, 2020

"Syntax" seems fine? But yeah, that makes sense to me generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
FP Issue Triaging
  
Needs Assignee
Development

No branches or pull requests

4 participants