From 40c201cd5bf151ca6b78c6ee6ad62fd339cb9a3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= <yangpanteng@gmail.com>
Date: Tue, 20 Dec 2022 20:01:30 +0800
Subject: [PATCH 1/2] feat(useAsyncState): Add onSuccess callbacks

---
 packages/core/useAsyncState/index.ts | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/packages/core/useAsyncState/index.ts b/packages/core/useAsyncState/index.ts
index d8cb1dfc6d0..1fcc5c8f8b1 100644
--- a/packages/core/useAsyncState/index.ts
+++ b/packages/core/useAsyncState/index.ts
@@ -10,7 +10,7 @@ export interface UseAsyncStateReturn<Data, Shallow extends boolean> {
   execute: (delay?: number, ...args: any[]) => Promise<Data>
 }
 
-export interface UseAsyncStateOptions<Shallow extends boolean> {
+export interface UseAsyncStateOptions<Shallow extends boolean, D = any> {
   /**
    * Delay for executing the promise. In milliseconds.
    *
@@ -33,6 +33,12 @@ export interface UseAsyncStateOptions<Shallow extends boolean> {
    */
   onError?: (e: unknown) => void
 
+  /**
+   * Callback when success is caught.
+   * @param {D} data
+   */
+  onSuccess?: (data: D) => void
+
   /**
    * Sets the state to initialState before executing the promise.
    *
@@ -71,17 +77,17 @@ export interface UseAsyncStateOptions<Shallow extends boolean> {
 export function useAsyncState<Data, Shallow extends boolean = true>(
   promise: Promise<Data> | ((...args: any[]) => Promise<Data>),
   initialState: Data,
-  options?: UseAsyncStateOptions<Shallow>,
+  options?: UseAsyncStateOptions<Shallow, Data>,
 ): UseAsyncStateReturn<Data, Shallow> {
   const {
     immediate = true,
     delay = 0,
     onError = noop,
+    onSuccess = noop,
     resetOnExecute = true,
     shallow = true,
     throwError,
   } = options ?? {}
-
   const state = shallow ? shallowRef(initialState) : ref(initialState)
   const isReady = ref(false)
   const isLoading = ref(false)
@@ -105,6 +111,7 @@ export function useAsyncState<Data, Shallow extends boolean = true>(
       const data = await _promise
       state.value = data
       isReady.value = true
+      onSuccess({ ...data })
     }
     catch (e) {
       error.value = e

From 595f4aafb3463a6a490a352f843241938d420951 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E4=B8=B6=E8=BF=9C=E6=96=B9?= <yangpanteng@gmail.com>
Date: Tue, 20 Dec 2022 20:29:49 +0800
Subject: [PATCH 2/2] feat(useAsyncState): Add onSuccess callbacks

---
 packages/core/useAsyncState/index.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/core/useAsyncState/index.ts b/packages/core/useAsyncState/index.ts
index 1fcc5c8f8b1..6a7c978612e 100644
--- a/packages/core/useAsyncState/index.ts
+++ b/packages/core/useAsyncState/index.ts
@@ -111,7 +111,7 @@ export function useAsyncState<Data, Shallow extends boolean = true>(
       const data = await _promise
       state.value = data
       isReady.value = true
-      onSuccess({ ...data })
+      onSuccess(data)
     }
     catch (e) {
       error.value = e