Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UseThrottleFn does not call function - completely broken #2618

Closed
7 tasks done
RPainter8West opened this issue Jan 5, 2023 · 2 comments · Fixed by #2620
Closed
7 tasks done

UseThrottleFn does not call function - completely broken #2618

RPainter8West opened this issue Jan 5, 2023 · 2 comments · Fixed by #2620

Comments

@RPainter8West
Copy link

Describe the bug

In version 9.9.0 this function works

const ZoomToPointsThrottled = useThrottleFn(
(force: boolean) => {
ZoomToPoints(force);
},
1500,
true,
false
);

In version 9.10.0 the ZoomToPoints function is never called. I tried removing the "force" parameter from both the throttle and the called functions, but this made no difference.

Problem seems to have been introduced in pull request: #2580

Rolling back to 9.9.0 fixes the problem for me.

The same can be seen in the linked reproduction project. The "Increment Throttled" button works in 9.9.0 but not in 9.10.0

Reproduction

https://stackblitz.com/edit/vitejs-vite-bjrjmi/?file=package.json,src%2FApp.vue

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (8) x64 11th Gen Intel(R) Core(TM) i7-1165G7 @ 2.80GHz
    Memory: 658.50 MB / 15.69 GB
  Binaries:
    Node: 16.19.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 9.2.0 - ~\AppData\Roaming\npm\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.963.0), Chromium (108.0.1462.46)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @vueuse/core: 9.10.0 => 9.10.0
    vue: 3.2.45 => 3.2.45

Used Package Manager

npm

Validations

@RPainter8West
Copy link
Author

This is still a problem in v9.11.1
Reproduction example updated.

@RPainter8West RPainter8West changed the title UseThrottleFn stopped working in v9.10.0 UseThrottleFn does not call function - completely broken Jan 30, 2023
@RPainter8West
Copy link
Author

I can no longer reproduce the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant