feat(useActiveElement): support shadow roots #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpschen
previously approved these changes
Dec 30, 2022
Assuming you have a DOM structure like so:
```
body
my-element
#shadow-root
input
```
When the `input` becomes active, the outer document's `activeElement`
will actually be `my-element`, _not_ the input.
Each shadow root has its own `activeElement` in case you want to get
hold of the inner element in these cases.
This adds support to `useActiveElement` such that you can pass a shadow
root as the document to observe the active element of.
43081j
force-pushed
the
shady-active-elements
branch
from
576af4b
to
d3ac60e
Compare
|
rebased onto master since it was out of date fyi |
antfu
changed the title
antfu
previously approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming you have a DOM structure like so:
When the
inputbecomes active, the outer document'sactiveElementwill actually bemy-element, not the input.Each shadow root has its own
activeElementin case you want to get hold of the inner element in these cases.This adds support to
useActiveElementsuch that you can pass a shadow root as the document to observe the active element of.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).let me know if there's some reason you wouldn't want this or it needs doing differently and ill update.