Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useTimeAgo): add floor and ceil value calculation #2543

Merged
merged 2 commits into from Dec 16, 2022

Conversation

userquin
Copy link
Contributor

Description

The value is always rounded on format calculation.

closes #2542

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@userquin userquin marked this pull request as draft December 14, 2022 18:04
@userquin userquin marked this pull request as ready for review December 14, 2022 18:21
@userquin userquin marked this pull request as draft December 15, 2022 01:01
@userquin
Copy link
Contributor Author

I need to do some checks...

@userquin userquin marked this pull request as ready for review December 15, 2022 20:59
@antfu antfu merged commit a7dc61b into vueuse:main Dec 16, 2022
@userquin userquin deleted the feat/timeago/configurable-diff-eval branch December 16, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(useTimeAgo): allow calculate diff also with ceil or floor
2 participants