Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTextareaAutosize): support changes of element width #2541

Merged
merged 1 commit into from Dec 16, 2022

Conversation

dpschen
Copy link
Contributor

@dpschen dpschen commented Dec 13, 2022

Description

If the size of a textarea is changed by other stuff than the window width useTextareaAutosize currently breaks. By watching the textarea via useResizeObserver we make sure a change in width is accounted for.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit ebd4852 into vueuse:main Dec 16, 2022
@dpschen dpschen deleted the useTextareaAutosize-fix-element-resize branch February 1, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants