Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(onClickOutside): allow selector strings for ignore list #2439

Merged
merged 2 commits into from Dec 20, 2022
Merged

feat(onClickOutside): allow selector strings for ignore list #2439

merged 2 commits into from Dec 20, 2022

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Nov 13, 2022 •
edited

Description

Warning
Built on top of #2438. It should be merged before this PR.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sibbng sibbng mentioned this pull request Dec 20, 2022
Closed
4 tasks
@antfu antfu merged commit 7b3db82 into vueuse:main Dec 20, 2022
@sibbng sibbng deleted the feat/onclickoutside-selector-string branch December 20, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sibbng @antfu