New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useScrollLock): fix iOS touchmove bug #2362
Conversation
Not sure why the test is failing, should have nothing to do with the proposed changes |
@webfansplz After some more tests I ran into problems with my original solution. I believe the only way to truly solve this is by checking for Caveat is that the user needs to explicitly set the overflow to scroll to keep elements scrollable on iOS. |
@antfu would be happy to get your opinion on this implementation! |
@robinscholz This problem still exists at |
Description
This PR solves iOS touchmove issues that prevent any children elements of the locked element from scrolling. I believe this will solve #2278.
Additional context
I believe there are no breaking changes, however it'd be good to confirm this with a few different devices.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).