Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useDateFormat): support MMM and MMMM formatter #2234

Merged
merged 1 commit into from Sep 21, 2022

Conversation

777Vasya77
Copy link
Contributor

@777Vasya77 777Vasya77 commented Sep 20, 2022

Description

Support MMM and MMMM format. #1641


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@777Vasya77
Copy link
Contributor Author

@webfansplz, please check it

@antfu antfu merged commit 39b2776 into vueuse:main Sep 21, 2022
@joshistoast
Copy link

I'm still encountering this issue after this PR, mainly using MMM or MMMM results in a 500 error despite being on version 9.2.0

@777Vasya77
Copy link
Contributor Author

I'm still encountering this issue after this PR, mainly using MMM or MMMM results in a 500 error despite being on version 9.2.0

This PR is not included in version 9.2.0 change log

@sxzz
Copy link
Member

sxzz commented Sep 22, 2022

Haven't been released yet.

The merge commit doesn’t appear in any tags

@joshistoast
Copy link

joshistoast commented Sep 22, 2022

I'm still encountering this issue after this PR, mainly using MMM or MMMM results in a 500 error despite being on version 9.2.0

This PR is not included in version 9.2.0 change log

You're completely right, I assumed that it was already available given that the documentation mentions it as a feature.

@777Vasya77
Copy link
Contributor Author

@joshwcorbett Pay attention to the section Changlog in the documentation, the status for the PR is indicated there doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants