Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(until): .not returns new instance #2224

Merged
merged 4 commits into from Sep 26, 2022
Merged

fix(until): .not returns new instance #2224

merged 4 commits into from Sep 26, 2022

Conversation

lsdsjy
Copy link
Contributor

@lsdsjy lsdsjy commented Sep 19, 2022

Description

Fixes #2223

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu
Copy link
Member

antfu commented Sep 19, 2022

Can we have some tests for it? Thanks

@antfu antfu enabled auto-merge (squash) September 26, 2022 01:43
@antfu antfu merged commit 1f6567f into vueuse:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

until.not is not implemented correctly
2 participants
@lsdsjy @antfu