Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templateRef): add Component type #2203

Merged
merged 2 commits into from Sep 16, 2022
Merged

Conversation

Holi0317
Copy link
Contributor

CC: @murongg

Fixes #1757, replace PR #1760

Description

Allow templateRef to support vue component type

Additional context

This replaces PR #1760 by rebasing the latest main branch, then add a test case for the new use case for templateRef function.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate. Replacing another PR
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reference only.

}))

expect(vm.targetEl).toBeDefined()
expect(vm.targetEl.$options.name).toBe('ChildComponent')

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to use unmount when you're done.

@antfu antfu merged commit cd7984c into vueuse:main Sep 16, 2022
@antfu antfu mentioned this pull request Sep 16, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

templateRef type argument does not support vue copmponent
4 participants