Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onClickOutside): put ignore logic on pointerdown event #2198

Merged
merged 2 commits into from Sep 16, 2022

Conversation

GODLiangCY
Copy link
Contributor

Description

fix #2196

Additional context

put ignore logic on pointerdown event, making sure the proper behavior.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

packages/core/onClickOutside/index.ts Outdated Show resolved Hide resolved
packages/core/onClickOutside/index.ts Outdated Show resolved Hide resolved
@antfu antfu added the no stale label Sep 14, 2022
@antfu antfu merged commit a3742d7 into vueuse:main Sep 16, 2022
@GODLiangCY GODLiangCY deleted the fix/onClickOutside branch September 16, 2022 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onClickOutside: listen only to mousedown event for ignore elements
3 participants