Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(onKeyStroke): support capture all handler #2197

Merged
merged 1 commit into from Sep 16, 2022

Conversation

azaleta
Copy link
Contributor

@azaleta azaleta commented Sep 14, 2022

Description

linked issue: #2195

null/undifined is not necessary here. Also () => false as well.
Add a overload for better usage and fix directive.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu added the no stale label Sep 14, 2022
@antfu antfu changed the title refact(onKeyStroke): improve type feat(onKeyStroke): support capture all handler Sep 16, 2022
@antfu antfu merged commit 86c12b9 into vueuse:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants