New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useDraggable): use clientX
instead of pageX
, close #2053
#2054
Conversation
x: e.pageX - rect.left, | ||
y: e.pageY - rect.top, | ||
x: e.clientX - rect.left, | ||
y: e.clientY - rect.top, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One interesting tidbit is that this pretty much assumes "position: fixed". That's also the only thing that can be implemented in a sane manner, as far as I can tell.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still fixes a major bug for me |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
The demo on the documentation site is still bugged, so I assume that this fix is still relevant. No idea why the stale bot closed the issue, despite commenting on it. That seems like a mistake. |
clientX
instead of pageX
, close #2053
Follows upstream change: vueuse/vueuse#2054
Follows upstream change: vueuse/vueuse#2054
Follows upstream change: vueuse/vueuse#2054
Follows upstream change: vueuse/vueuse#2054
Description
Fix #2053
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).