Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useDateFormat): support meridiem format #2011

Merged
merged 6 commits into from Sep 23, 2022

Conversation

huynl-96
Copy link
Contributor

Description

  • In the REGEX_FORMAT, we've already supported a|A regex for meridiem but there is no logic to handle this yet.
  • Support format with periods, such as a.m., p.m.
  • Customizable meridiem for other locales

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu requested a review from webfansplz July 29, 2022 11:48
@huynl-96
Copy link
Contributor Author

@webfansplz Could you help me review this PR when you're available? Thanks

@antfu antfu merged commit 3fda645 into vueuse:main Sep 23, 2022
@huynl-96 huynl-96 deleted the feat/date-format-meridiem branch September 23, 2022 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants